chromecast/browser/metrics/cast_metrics_service_client.h - Issue 2248793002: Remove OnRecordingDisabled() metrics client interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add helper function Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/metrics/metrics_reporting_state.cc ('k') | chromecast/browser/metrics/cast_metrics_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index a0178d19fbc8ca94fecd312005b0698479bc1abd..10fee3e4e95d25d89c0a3d5b6b2c85e511d41b75 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -69,7 +69,6 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient,

// ::metrics::MetricsServiceClient:

::metrics::MetricsService* GetMetricsService() override;

void SetMetricsClientId(const std::string& client_id) override;

- void OnRecordingDisabled() override;

bool IsOffTheRecordSessionActive() override;

int32_t GetProduct() override;

std::string GetApplicationLocale() override;