Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 224833002: Implement DataCue interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index fc9f9407e9430a93959f29ac38190513e9f3511a..ddfaa74ab451582d2e2355be76ae5097968b03be 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -77,13 +77,16 @@ public:
bool isActive();
void setIsActive(bool);
- virtual void updateDisplay(const IntSize& videoSize, HTMLDivElement& container) = 0;
+ virtual void updateDisplay(const IntSize& videoSize, HTMLDivElement& container) { };
// FIXME: Consider refactoring to eliminate or merge the following three members.
// https://code.google.com/p/chromium/issues/detail?id=322434
- virtual void updateDisplayTree(double movieTime) = 0;
- virtual void removeDisplayTree() = 0;
- virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) = 0;
+ virtual void updateDisplayTree(double movieTime) { };
+ virtual void removeDisplayTree() { };
+ virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) { };
+
+ enum CueType { WebVTT, Data };
+ virtual CueType cueType() const = 0;
philipj_slow 2014/04/04 14:54:33 isVTTCue would be more in line with how the Node h
Brendan Long 2014/04/04 15:07:22 So, remove CueType, and add a 'bool isVTTCue()'? D
virtual const AtomicString& interfaceName() const OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698