Source/core/html/track/vtt/VTTCue.h - Issue 224833002: Implement DataCue interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTCue.h

Issue 224833002: Implement DataCue interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/vtt/VTTCue.h

diff --git a/Source/core/html/track/vtt/VTTCue.h b/Source/core/html/track/vtt/VTTCue.h

index 539800500eaf007d3328a726d3cebd7daeb810a3..f61970838368ac15be6993c68704627b28ce648c 100644

--- a/Source/core/html/track/vtt/VTTCue.h

+++ b/Source/core/html/track/vtt/VTTCue.h

@@ -131,6 +131,8 @@ public:

};

CueAlignment getAlignment() const { return m_cueAlignment; }

+ virtual CueType cueType() const OVERRIDE { return WebVTT; }

virtual ExecutionContext* executionContext() const OVERRIDE;

#ifndef NDEBUG

@@ -188,7 +190,7 @@ private:

};

// VTTCue is currently the only TextTrackCue subclass.

acolwell GONE FROM CHROMIUM 2014/04/04 23:25:27 nit: Please remove this comment now that it is no

-DEFINE_TYPE_CASTS(VTTCue, TextTrackCue, cue, true, true);

+DEFINE_TYPE_CASTS(VTTCue, TextTrackCue, cue, cue->cueType() == TextTrackCue::WebVTT, cue.cueType() == TextTrackCue::WebVTT);

} // namespace WebCore