Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: Source/core/html/track/TextTrackCue.h

Issue 224833002: Implement DataCue interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 70
71 int cueIndex(); 71 int cueIndex();
72 void invalidateCueIndex(); 72 void invalidateCueIndex();
73 73
74 using EventTarget::dispatchEvent; 74 using EventTarget::dispatchEvent;
75 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) OVERRIDE; 75 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) OVERRIDE;
76 76
77 bool isActive(); 77 bool isActive();
78 void setIsActive(bool); 78 void setIsActive(bool);
79 79
80 virtual void updateDisplay(const IntSize& videoSize, HTMLDivElement& contain er) = 0; 80 virtual void updateDisplay(const IntSize& videoSize, HTMLDivElement& contain er) { };
81 81
82 // FIXME: Consider refactoring to eliminate or merge the following three mem bers. 82 // FIXME: Consider refactoring to eliminate or merge the following three mem bers.
83 // https://code.google.com/p/chromium/issues/detail?id=322434 83 // https://code.google.com/p/chromium/issues/detail?id=322434
84 virtual void updateDisplayTree(double movieTime) = 0; 84 virtual void updateDisplayTree(double movieTime) { };
85 virtual void removeDisplayTree() = 0; 85 virtual void removeDisplayTree() { };
86 virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) = 0; 86 virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) { };
87
88 enum CueType { WebVTT, Data };
89 virtual CueType cueType() const = 0;
philipj_slow 2014/04/04 14:54:33 isVTTCue would be more in line with how the Node h
Brendan Long 2014/04/04 15:07:22 So, remove CueType, and add a 'bool isVTTCue()'? D
87 90
88 virtual const AtomicString& interfaceName() const OVERRIDE; 91 virtual const AtomicString& interfaceName() const OVERRIDE;
89 92
90 #ifndef NDEBUG 93 #ifndef NDEBUG
91 virtual String toString() const = 0; 94 virtual String toString() const = 0;
92 #endif 95 #endif
93 96
94 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter); 97 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
95 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit); 98 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
96 99
(...skipping 11 matching lines...) Expand all
108 111
109 TextTrack* m_track; 112 TextTrack* m_track;
110 113
111 bool m_isActive : 1; 114 bool m_isActive : 1;
112 bool m_pauseOnExit : 1; 115 bool m_pauseOnExit : 1;
113 }; 116 };
114 117
115 } // namespace WebCore 118 } // namespace WebCore
116 119
117 #endif 120 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698