Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2247823002: Implement OfflinePageDownloadBridge::startDownload (Closed)

Created:
4 years, 4 months ago by Dmitry Titov
Modified:
4 years, 4 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement OfflinePageDownloadBridge::startDownload BUG=630817 Committed: https://crrev.com/e3ac57dc9821219deb7579832e8eda43de60a415 Cr-Commit-Position: refs/heads/master@{#412042}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : CR feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h View 1 3 chunks +21 lines, -8 lines 0 comments Download
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc View 1 2 4 chunks +45 lines, -1 line 1 comment Download

Messages

Total messages: 14 (8 generated)
Dmitry Titov
PTAL
4 years, 4 months ago (2016-08-15 19:35:48 UTC) #3
fgorski
lgtm https://codereview.chromium.org/2247823002/diff/20001/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc File chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc (right): https://codereview.chromium.org/2247823002/diff/20001/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc#newcode144 chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc:144: offline_pages::OfflinePageModel* offline_page_model = nit: move the offline_page_model check ...
4 years, 4 months ago (2016-08-15 19:59:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247823002/40001
4 years, 4 months ago (2016-08-15 20:22:07 UTC) #9
Pete Williamson
https://codereview.chromium.org/2247823002/diff/40001/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc File chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc (right): https://codereview.chromium.org/2247823002/diff/40001/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc#newcode151 chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc:151: url, client_id, std::move(archiver), FYI - This line has an ...
4 years, 4 months ago (2016-08-15 20:52:58 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-15 20:55:45 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 21:00:49 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e3ac57dc9821219deb7579832e8eda43de60a415
Cr-Commit-Position: refs/heads/master@{#412042}

Powered by Google App Engine
This is Rietveld 408576698