Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

Issue 2247823002: Implement OfflinePageDownloadBridge::startDownload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
index ad394febb38444a512b24740e2d4b352ab405188..41f94ec8f1ce6ff056f75fc18b2773fbdcbfca40 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
@@ -10,6 +10,7 @@
#include "base/android/jni_android.h"
#include "base/android/jni_weak_ref.h"
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "base/supports_user_data.h"
#include "components/offline_pages/downloads/download_ui_adapter.h"
@@ -33,26 +34,35 @@ class OfflinePageDownloadBridge : public DownloadUIAdapter::Observer {
static bool Register(JNIEnv* env);
- void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+ void Destroy(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
- void GetAllItems(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jobject>& j_result_obj);
+ void GetAllItems(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jobject>& j_result_obj);
base::android::ScopedJavaLocalRef<jobject> GetItemByGuid(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& j_guid);
- void DeleteItemByGuid(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jstring>& j_guid);
+ void DeleteItemByGuid(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& j_guid);
base::android::ScopedJavaLocalRef<jstring> GetOfflineUrlByGuid(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& j_guid);
+ void StartDownload(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jobject>& j_tab);
+
// DownloadUIAdapter::Observer implementation.
void ItemsLoaded() override;
void ItemAdded(const DownloadUIItem& item) override;
@@ -60,11 +70,14 @@ class OfflinePageDownloadBridge : public DownloadUIAdapter::Observer {
void ItemDeleted(const std::string& guid) override;
private:
- JavaObjectWeakGlobalRef weak_java_ref_;
+ void SavePageCallback(OfflinePageModel::SavePageResult result,
+ int64_t offline_id);
+ JavaObjectWeakGlobalRef weak_java_ref_;
// Not owned.
DownloadUIAdapter* download_ui_adapter_;
+ base::WeakPtrFactory<OfflinePageDownloadBridge> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(OfflinePageDownloadBridge);
};

Powered by Google App Engine
This is Rietveld 408576698