chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java - Issue 2247823002: Implement OfflinePageDownloadBridge::startDownload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2247823002: Implement OfflinePageDownloadBridge::startDownload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h » ('j') | chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

index c1d3328db4fc3a8d6f3d12085e244f1796799409..dec2c4bdc110017152103a596d2b90f2e96414f9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

@@ -148,7 +148,7 @@ public class OfflinePageDownloadBridge {

* @param tab a tab contents of which will be saved locally.

public void startDownload(Tab tab) {

- // TODO(dimich): Next patch.

+ nativeStartDownload(mNativeOfflinePageDownloadBridge, tab);

}

/**

@@ -214,4 +214,5 @@ public class OfflinePageDownloadBridge {

long nativeOfflinePageDownloadBridge, String guid);

native void nativeDeleteItemByGuid(long nativeOfflinePageDownloadBridge, String guid);

native String nativeGetOfflineUrlByGuid(long nativeOfflinePageDownloadBridge, String guid);

+ native void nativeStartDownload(long nativeOfflinePageDownloadBridge, Tab tab);

}