chrome/browser/ui/views/frame/glass_browser_frame_view.cc - Issue 2247563002: Change status bubble rendering at hidpi and when there is no client edge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Issue 2247563002: Change status bubble rendering at hidpi and when there is no client edge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments and nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/status_bubble_views.h » ('j') | chrome/browser/ui/views/status_bubble_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/glass_browser_frame_view.cc

diff --git a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

index d8db91ba84ee068f9d1a97bc2d5cbfc00fda3cdf..2219db73325f2029de2826be420e9026f4c769ae 100644

--- a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

+++ b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

@@ -338,7 +338,7 @@ bool GlassBrowserFrameView::DoesIntersectRect(const views::View* target,

int GlassBrowserFrameView::ClientBorderThickness(bool restored) const {

// The frame ends abruptly at the 1 pixel window border drawn by Windows 10.

- if (base::win::GetVersion() >= base::win::VERSION_WIN10)

+ if (!browser_view()->HasClientEdge())

return 0;

if ((frame()->IsMaximized() || frame()->IsFullscreen()) && !restored)