Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2247563002: Change status bubble rendering at hidpi and when there is no client edge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments and nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index acd977a0eb57d163b4245e7284df2bd55ee92176..ffaa5138b1210436397e50924b5a0e0868455af1 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -167,6 +167,7 @@
#endif
#if defined(OS_WIN)
+#include "base/win/windows_version.h"
#include "chrome/browser/win/jumplist.h"
#include "ui/gfx/color_palette.h"
#include "ui/native_theme/native_theme_dark_win.h"
@@ -543,7 +544,8 @@ void BrowserView::Paint1pxHorizontalLine(gfx::Canvas* canvas,
}
void BrowserView::InitStatusBubble() {
- status_bubble_.reset(new StatusBubbleViews(contents_web_view_));
+ status_bubble_.reset(
+ new StatusBubbleViews(contents_web_view_, HasClientEdge()));
contents_web_view_->SetStatusBubble(status_bubble_.get());
}
@@ -607,6 +609,15 @@ bool BrowserView::IsRegularOrGuestSession() const {
return profiles::IsRegularOrGuestSession(browser_.get());
}
+bool BrowserView::HasClientEdge() const {
+#if defined(OS_WIN)
+ return base::win::GetVersion() < base::win::VERSION_WIN10 ||
+ !frame_->ShouldUseNativeFrame();
+#else
+ return true;
+#endif
+}
+
bool BrowserView::GetAccelerator(int cmd_id,
ui::Accelerator* accelerator) const {
// We retrieve the accelerator information for standard accelerators

Powered by Google App Engine
This is Rietveld 408576698