Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/ui/views/status_bubble_views.h

Issue 2247563002: Change status bubble rendering at hidpi and when there is no client edge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments and nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/status_bubble_views.h
diff --git a/chrome/browser/ui/views/status_bubble_views.h b/chrome/browser/ui/views/status_bubble_views.h
index a18136c4fe68da2035dac1da7ed1168aa6471a03..5e753d8a791b56073a2c716f5902ad881487b321 100644
--- a/chrome/browser/ui/views/status_bubble_views.h
+++ b/chrome/browser/ui/views/status_bubble_views.h
@@ -35,7 +35,7 @@ class StatusBubbleViews : public StatusBubble {
static const int kTotalVerticalPadding = 7;
// |base_view| is the view that this bubble is positioned relative to.
- explicit StatusBubbleViews(views::View* base_view);
+ StatusBubbleViews(views::View* base_view, bool has_client_edge);
~StatusBubbleViews() override;
views::View* base_view() { return base_view_; }
@@ -139,6 +139,10 @@ class StatusBubbleViews : public StatusBubble {
// change size immediately, with no hover.
bool is_expanded_;
+ // Whether or not the frame that the bubble will be painting inside has a
+ // client edge. Affects layout.
+ const bool has_client_edge_;
+
// Times expansion of status bubble when URL is too long for standard width.
base::WeakPtrFactory<StatusBubbleViews> expand_timer_factory_;

Powered by Google App Engine
This is Rietveld 408576698