Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 2247483003: [DevTools] Removed isInternalScript flag from protocol (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-internal-script-flag
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed isInternalScript flag from protocol Internal scripts in DevTools: - InjectedScriptSource.js, - DebuggerScript.js, - callFunctionOn uses internal script to compile function declaration and call arguments. We can ignore these scripts, not report them to frontend and never stop in them since they are a part of debugger implementation. BUG=635947 R=dgozman@chromium.org Committed: https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708 Cr-Commit-Position: refs/heads/master@{#411886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -86 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/sources/debugger/dont-report-injected-script.html View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger/dont-report-injected-script-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger/internal-script-flag-for-injected-script.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger/internal-script-flag-for-injected-script-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 3 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-12 22:34:48 UTC) #1
dgozman
lgtm
4 years, 4 months ago (2016-08-12 23:20:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247483003/1
4 years, 4 months ago (2016-08-13 05:10:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 07:43:43 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 07:46:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708
Cr-Commit-Position: refs/heads/master@{#411886}

Powered by Google App Engine
This is Rietveld 408576698