[DevTools] Don't mark scripts from V8LazyEventListener as internal

[DevTools] Don't mark scripts from V8LazyEventListener as internal

Otherwise inline event handlers will be skipped during stepping.

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/9682a2b14ca6636ce3d716ef851dd5a9ae0e2721
Cr-Commit-Position: refs/heads/master@{#411874}

[kozy, 2016-08-12 21:39:29]

Dmitry, please take a look!

[kozy, 2016-08-12 23:07:59]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 23:08:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-08-12 23:14:13]

lgtm

https://codereview.chromium.org/2242893004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html
(right):

https://codereview.chromium.org/2242893004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html:88:
return new Promise(fulfill => InspectorTest.eventHandler[eventName] = fulfill);
Please remove from eventHandler after it's called.

[kozy, 2016-08-12 23:25:45]

Description was changed from

==========
[DevTools] Don't mark scripts from V8LazyEventListener as internal

Otherwise inline event handlers will be skipped during stepping.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Don't mark scripts from V8LazyEventListener as internal

Otherwise inline event handlers will be skipped during stepping.

BUG=none
R=dgozman@chromium.org
==========

[kozy, 2016-08-12 23:25:45]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-08-12 23:26:06]

Pavel, please take a look. I need owner lgtm.

[kozy, 2016-08-12 23:38:36]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[kozy, 2016-08-12 23:39:00]

all done

https://codereview.chromium.org/2242893004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html
(right):

https://codereview.chromium.org/2242893004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html:88:
return new Promise(fulfill => InspectorTest.eventHandler[eventName] = fulfill);
On 2016/08/12 23:14:13, dgozman wrote:
> Please remove from eventHandler after it's called.

Done.

[commit-bot: I haz the power, 2016-08-12 23:39:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-08-13 00:10:57]

lgtm

[kozy, 2016-08-13 00:12:26]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-08-13 00:12:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-13 00:12:32]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2242893004/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-08-13 00:13:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 04:18:25]

Description was changed from

==========
[DevTools] Don't mark scripts from V8LazyEventListener as internal

Otherwise inline event handlers will be skipped during stepping.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Don't mark scripts from V8LazyEventListener as internal

Otherwise inline event handlers will be skipped during stepping.

BUG=none
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-08-13 04:18:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-13 04:20:07]

Description was changed from

==========
[DevTools] Don't mark scripts from V8LazyEventListener as internal

Otherwise inline event handlers will be skipped during stepping.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Don't mark scripts from V8LazyEventListener as internal

Otherwise inline event handlers will be skipped during stepping.

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/9682a2b14ca6636ce3d716ef851dd5a9ae0e2721
Cr-Commit-Position: refs/heads/master@{#411874}
==========

[commit-bot: I haz the power, 2016-08-13 04:20:08]

Patchset 3 (id:??) landed as
https://crrev.com/9682a2b14ca6636ce3d716ef851dd5a9ae0e2721
Cr-Commit-Position: refs/heads/master@{#411874}