third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp - Issue 2247483003: [DevTools] Removed isInternalScript flag from protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Issue 2247483003: [DevTools] Removed isInternalScript flag from protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-internal-script-flag

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

index f5898b4a9068e174693006b0fc80b7b195e11584..bed7f8b9c067a9bbe27217e739241952901ce70a 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

@@ -508,6 +508,8 @@ void V8Debugger::handleV8DebugEvent(const v8::Debug::EventDetails& eventDetails)

v8::Context::Scope contextScope(debuggerContext());

v8::Local<v8::Value> argv[] = { eventDetails.GetEventData() };

v8::Local<v8::Value> value = callDebuggerMethod("getAfterCompileScript", 1, argv).ToLocalChecked();

+ if (value->IsNull())

+ return;

DCHECK(value->IsObject());

v8::Local<v8::Object> scriptObject = v8::Local<v8::Object>::Cast(value);

agent->didParseSource(wrapUnique(new V8DebuggerScript(m_isolate, scriptObject, inLiveEditScope)), event == v8::AfterCompile);