Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2246923004: Merge TextCheckingHelper into SpellChecker Part 4 (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CleanupSpellCheckerAfterMoving
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge TextCheckingHelper into SpellChecker Part 4 This patch removes useless includes and forward declarations from TextCheckingHelper.h/cpp. The removed code has become useless after moving code to SpellChecker in previous patches. This patch is part 4 of a series of patches: - Part 1: http://crrev.com/2246053003 - Part 2: http://crrev.com/2253523002 - Part 3: http://crrev.com/2247273002 BUG=619452 TEST=n/a; no behavior change Committed: https://crrev.com/e10a153d1b5497dc3494ebe963abc574a06850cd Cr-Commit-Position: refs/heads/master@{#412423}

Patch Set 1 #

Patch Set 2 : Also remove useless forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-17 02:03:51 UTC) #9
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-17 02:05:34 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 2247273002 Patch 40001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-17 02:06:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246923004/20001
4 years, 4 months ago (2016-08-17 02:16:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 02:20:01 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 02:21:45 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e10a153d1b5497dc3494ebe963abc574a06850cd
Cr-Commit-Position: refs/heads/master@{#412423}

Powered by Google App Engine
This is Rietveld 408576698