chrome/browser/translate/translate_tab_helper.h - Issue 224723025: Componentize TranslateManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_tab_helper.h

Issue 224723025: Componentize TranslateManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/translate/translate_tab_helper.h

diff --git a/chrome/browser/translate/translate_tab_helper.h b/chrome/browser/translate/translate_tab_helper.h

index 3e66181874e10ac14610698003a7396aae0fccfb..aef6e184f1f2a9f72daf11f42275fbcf67e67d9e 100644

--- a/chrome/browser/translate/translate_tab_helper.h

+++ b/chrome/browser/translate/translate_tab_helper.h

@@ -94,6 +94,8 @@ class TranslateTabHelper

TranslateErrors::Type error_type,

bool triggered_from_menu) OVERRIDE;

virtual bool IsTranslatableURL(const GURL& url) OVERRIDE;

+ virtual void ShowReportLanguageDetectionErrorUI(const GURL& report_url)

+ OVERRIDE;

droger 2014/04/08 14:10:55 Nit: do not break here, this is a bug in clang-for

blundell 2014/04/08 20:01:53 Done.

private:

explicit TranslateTabHelper(content::WebContents* web_contents);