Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/translate/translate_tab_helper.h

Issue 224723025: Componentize TranslateManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 virtual TranslateDriver* GetTranslateDriver() OVERRIDE; 87 virtual TranslateDriver* GetTranslateDriver() OVERRIDE;
88 virtual PrefService* GetPrefs() OVERRIDE; 88 virtual PrefService* GetPrefs() OVERRIDE;
89 virtual scoped_ptr<TranslatePrefs> GetTranslatePrefs() OVERRIDE; 89 virtual scoped_ptr<TranslatePrefs> GetTranslatePrefs() OVERRIDE;
90 virtual TranslateAcceptLanguages* GetTranslateAcceptLanguages() OVERRIDE; 90 virtual TranslateAcceptLanguages* GetTranslateAcceptLanguages() OVERRIDE;
91 virtual void ShowTranslateUI(translate::TranslateStep step, 91 virtual void ShowTranslateUI(translate::TranslateStep step,
92 const std::string source_language, 92 const std::string source_language,
93 const std::string target_language, 93 const std::string target_language,
94 TranslateErrors::Type error_type, 94 TranslateErrors::Type error_type,
95 bool triggered_from_menu) OVERRIDE; 95 bool triggered_from_menu) OVERRIDE;
96 virtual bool IsTranslatableURL(const GURL& url) OVERRIDE; 96 virtual bool IsTranslatableURL(const GURL& url) OVERRIDE;
97 virtual void ShowReportLanguageDetectionErrorUI(const GURL& report_url)
98 OVERRIDE;
droger 2014/04/08 14:10:55 Nit: do not break here, this is a bug in clang-for
blundell 2014/04/08 20:01:53 Done.
97 99
98 private: 100 private:
99 explicit TranslateTabHelper(content::WebContents* web_contents); 101 explicit TranslateTabHelper(content::WebContents* web_contents);
100 friend class content::WebContentsUserData<TranslateTabHelper>; 102 friend class content::WebContentsUserData<TranslateTabHelper>;
101 103
102 // content::WebContentsObserver implementation. 104 // content::WebContentsObserver implementation.
103 virtual void NavigationEntryCommitted( 105 virtual void NavigationEntryCommitted(
104 const content::LoadCommittedDetails& load_details) OVERRIDE; 106 const content::LoadCommittedDetails& load_details) OVERRIDE;
105 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 107 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
106 virtual void DidNavigateAnyFrame( 108 virtual void DidNavigateAnyFrame(
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 167
166 // Necessary for binding the callback to HandleCLDDataRequest on the blocking 168 // Necessary for binding the callback to HandleCLDDataRequest on the blocking
167 // pool and for delaying translation initialization until the page has 169 // pool and for delaying translation initialization until the page has
168 // finished loading on a reload. 170 // finished loading on a reload.
169 base::WeakPtrFactory<TranslateTabHelper> weak_pointer_factory_; 171 base::WeakPtrFactory<TranslateTabHelper> weak_pointer_factory_;
170 172
171 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper); 173 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper);
172 }; 174 };
173 175
174 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 176 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/translate/translate_service.cc ('k') | chrome/browser/translate/translate_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698