Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 224723025: Componentize TranslateManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_tab_helper.cc
diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc
index 7083912db0ac6d92351bbf89bd65be98cc01ab45..8dcbd23cd8659dae84c7325a8a5421f5e1075485 100644
--- a/chrome/browser/translate/translate_tab_helper.cc
+++ b/chrome/browser/translate/translate_tab_helper.cc
@@ -11,10 +11,10 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/translate/translate_accept_languages_factory.h"
#include "chrome/browser/translate/translate_infobar_delegate.h"
-#include "chrome/browser/translate/translate_manager.h"
#include "chrome/browser/translate/translate_service.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/translate/translate_bubble_factory.h"
@@ -23,6 +23,7 @@
#include "components/translate/core/browser/page_translated_details.h"
#include "components/translate/core/browser/translate_accept_languages.h"
#include "components/translate/core/browser/translate_download_manager.h"
+#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_prefs.h"
#include "components/translate/core/common/language_detection_details.h"
#include "content/public/browser/navigation_details.h"
@@ -119,9 +120,10 @@ void TranslateTabHelper::GetTranslateLanguages(
Profile::FromBrowserContext(web_contents->GetBrowserContext());
Profile* original_profile = profile->GetOriginalProfile();
PrefService* prefs = original_profile->GetPrefs();
+ scoped_ptr<TranslatePrefs> translate_prefs = CreateTranslatePrefs(prefs);
if (!web_contents->GetBrowserContext()->IsOffTheRecord()) {
std::string auto_translate_language =
- TranslateManager::GetAutoTargetLanguage(*source, prefs);
+ TranslateManager::GetAutoTargetLanguage(*source, translate_prefs.get());
if (!auto_translate_language.empty()) {
*target = auto_translate_language;
return;
@@ -205,6 +207,19 @@ bool TranslateTabHelper::IsTranslatableURL(const GURL& url) {
return TranslateService::IsTranslatableURL(url);
}
+void TranslateTabHelper::ShowReportLanguageDetectionErrorUI(
+ const GURL& report_url) {
+ // We'll open the URL in a new tab so that the user can tell us more.
+ Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
+ if (!browser) {
+ NOTREACHED();
+ return;
+ }
+
+ chrome::AddSelectedTabWithURL(
+ browser, report_url, content::PAGE_TRANSITION_AUTO_BOOKMARK);
+}
+
bool TranslateTabHelper::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(TranslateTabHelper, message)

Powered by Google App Engine
This is Rietveld 408576698