[WebApk] Installation adds a homescreen shortcut.

[WebApk] Installation adds a homescreen shortcut.

Since installation is going through package installer directly and not
play, a shortcut isn't created. Add logic to listen for package
installation and manually create a shortcut (there is no callback/event
that can be listened to). Note if chrome is evicted, a shortcut won't be
created. As this is a temporary solution, it should be fine for now.
BUG=636107

[Yaron, 2016-08-18 17:37:38]

yfriedman@chromium.org changed reviewers:
+ dfalcantara@chromium.org, hanxi@chromium.org

[Yaron, 2016-08-18 17:37:39]

xi: WebApkInstaller
dan: ShortcutHelper

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:199:
context.sendBroadcast(createAddToHomeIntent("", shortcutTitle, bitmap, i));
i think the first param is unused and could be removed.

[gone, 2016-08-18 21:16:01]

lgtm

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:199:
context.sendBroadcast(createAddToHomeIntent("", shortcutTitle, bitmap, i));
On 2016/08/18 17:37:39, Yaron (limited availability) wrote:
> i think the first param is unused and could be removed.

Weird.  Follow up CL?

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
(right):

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java:66:

nit: extra newline

[Xi Han, 2016-08-19 14:23:24]

lgtm with nits.

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:188:
ApplicationInfo appInfo = null;
Move line 188 into the try-catch block.

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
(left):

https://codereview.chromium.org/2247183008/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java:25:

Revert please.

[Xi Han, 2016-08-26 17:55:10]

Description was changed from

==========
[WebApk] Installation adds a homescreen shortcut.

Since installation is going through package installer directly and not
play, a shortcut isn't created. Add logic to listen for package
installation and manually create a shortcut (there is no callback/event
that can be listened to). Note if chrome is evicted, a shortcut won't be
created. As this is a temporary solution, it should be fine for now.
BUG=636107
==========

to

==========
[WebApk] Installation adds a homescreen shortcut.

Since installation is going through package installer directly and not
play, a shortcut isn't created. Add logic to listen for package
installation and manually create a shortcut (there is no callback/event
that can be listened to). Note if chrome is evicted, a shortcut won't be
created. As this is a temporary solution, it should be fine for now.
BUG=636107
==========