Turning on optimizations for chromium code

Turning on optimizations for chromium code

This saves us 357kb of .dex size and 44kb of memory per process.

BUG=625704
Committed: https://crrev.com/e91be6b053a3e7daea66d63cc1d5a46fac86f4ff
Cr-Commit-Position: refs/heads/master@{#406099}

[smaier, 2016-07-06 18:40:53]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 18:41:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 21:09:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 21:09:29]

Dry run: This issue passed the CQ dry run.

[smaier, 2016-07-07 15:15:08]

smaier@chromium.org changed reviewers:
+ agrieve@chromium.org, wnwen@chromium.org, yfriedman@chromium.org

[smaier, 2016-07-07 15:15:09]

NOTE: depends on codereview.chromium.org/2123753005/

[agrieve, 2016-07-07 15:30:06]

We'll also need to wait until official builder scripts are updated to build &
test the for-test apk.

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/proguard.py
File build/android/gyp/proguard.py (right):

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/proguard....
build/android/gyp/proguard.py:15: DANGEROUS_OPTIMIZATIONS = [
nit: prefix with _ to denote as private to the module

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/proguard....
build/android/gyp/proguard.py:44: help='Turn on optimizations that are broken on
public '
nit: "Turn on optimizations which are known to have issues."

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/util/prog...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:133: '-optimizations', '!' +
optimization,
nit: put this all oneline:

cmd += [ '-optimizations', '!' + optimization ]

[smaier, 2016-07-08 14:59:11]

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/proguard.py
File build/android/gyp/proguard.py (right):

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/proguard....
build/android/gyp/proguard.py:15: DANGEROUS_OPTIMIZATIONS = [
On 2016/07/07 15:30:06, agrieve wrote:
> nit: prefix with _ to denote as private to the module

Done.

https://codereview.chromium.org/2127973003/diff/1/build/android/gyp/proguard....
build/android/gyp/proguard.py:44: help='Turn on optimizations that are broken on
public '
On 2016/07/07 15:30:06, agrieve wrote:
> nit: "Turn on optimizations which are known to have issues."

Done.

[smaier, 2016-07-08 17:12:36]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 17:12:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 20:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 20:29:31]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-07-18 17:42:40]

lgtm

[smaier, 2016-07-18 18:55:08]

The CQ bit was checked by smaier@chromium.org

[smaier, 2016-07-18 18:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2127973003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-07-18 18:56:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 21:23:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 21:23:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 21:25:03]

Description was changed from

==========
Turning on optimizations for chromium code

This saves us 357kb of .dex size and 44kb of memory per process.

BUG=625704
==========

to

==========
Turning on optimizations for chromium code

This saves us 357kb of .dex size and 44kb of memory per process.

BUG=625704

Committed: https://crrev.com/e91be6b053a3e7daea66d63cc1d5a46fac86f4ff
Cr-Commit-Position: refs/heads/master@{#406099}
==========

[commit-bot: I haz the power, 2016-07-18 21:25:04]

Patchset 3 (id:??) landed as
https://crrev.com/e91be6b053a3e7daea66d63cc1d5a46fac86f4ff
Cr-Commit-Position: refs/heads/master@{#406099}