Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2264713002: [WebApk] Update verification keys. (Closed)

Created:
4 years, 4 months ago by Yaron
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, dominickn+watch_chromium.org, hartmanng
Base URL:
https://chromium.googlesource.com/chromium/src.git@shortcut
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebApk] Update verification keys. Update keys to latest test keys and also break it out by channel.

Patch Set 1 #

Total comments: 1

Patch Set 2 : add canary key #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -61 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 2 chunks +1 line, -55 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHostSignature.template View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/android/webapk/channel_keys.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 chunk +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 2247183008 Patch 20001

Messages

Total messages: 4 (2 generated)
Yaron
https://codereview.chromium.org/2264713002/diff/1/chrome/android/webapk/channel_keys.h File chrome/android/webapk/channel_keys.h (right): https://codereview.chromium.org/2264713002/diff/1/chrome/android/webapk/channel_keys.h#newcode10 chrome/android/webapk/channel_keys.h:10: #define SIGNATURE missing waiting on this from Glenn
4 years, 4 months ago (2016-08-19 19:09:39 UTC) #2
Robert Sesek
4 years, 4 months ago (2016-08-24 17:07:42 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698