Mojo C++ bindings: extract code shared by different variants.

Mojo C++ bindings: extract code shared by different variants.

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).

BUG=632061
Committed: https://crrev.com/f0a39ef09ff38dd10fe170c9bad90b7e3d0f4ed1
Cr-Commit-Position: refs/heads/master@{#413415}

[yzshen1, 2016-08-15 21:42:54]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 21:43:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 21:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 21:49:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-08-15 23:02:20]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 23:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:09:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:09:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-08-16 15:22:37]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 15:23:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 15:28:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-08-16 16:31:25]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 16:31:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 16:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 16:38:34]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-08-16 20:15:12]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 20:15:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 20:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:22:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-08-16 21:31:37]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-16 22:25:09]

Description was changed from

==========
Mojo C++ bindings: extract code shared by different variants.

BUG=632061
==========

to

==========
Mojo C++ bindings: extract code shared by different variants.

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).


BUG=632061
==========

[yzshen1, 2016-08-16 22:25:09]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-08-16 22:26:56]

Hi, Ken.

Would you please take a look? Thanks!

[commit-bot: I haz the power, 2016-08-17 01:40:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 01:40:00]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-08-17 15:10:55]

lgtm

https://codereview.chromium.org/2247083003/diff/100001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl
(right):

https://codereview.chromium.org/2247083003/diff/100001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl:6: {%-  
set enum_name = enum|get_name_for_kind(flatten_nested_kind=True) %}
clever solution :)

[xlai (Olivia), 2016-08-17 17:16:52]

xlai@chromium.org changed reviewers:
+ xlai@chromium.org

[xlai (Olivia), 2016-08-17 17:16:53]

Thanks a lot for doing this!

[xlai (Olivia), 2016-08-17 17:16:58]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-08-17 17:17:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 17:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 17:23:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-08-17 17:28:17]

yzshen@chromium.org changed reviewers:
+ mvanouwerkerk@google.com

[yzshen1, 2016-08-17 17:28:18]

+Michael for owner review for
third_party/WebKit/Source/modules/notifications/NotificationManager.h

[xlai (Olivia), 2016-08-17 19:02:16]

xlai@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org
- mvanouwerkerk@google.com

[Michael van Ouwerkerk, 2016-08-18 11:40:46]

rs lgtm

[xlai (Olivia), 2016-08-18 19:08:12]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-08-18 19:08:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 21:59:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 21:59:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yzshen1, 2016-08-18 22:01:15]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-18 22:02:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 00:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 00:57:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xlai (Olivia), 2016-08-19 14:37:40]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-08-19 14:38:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 17:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 17:00:37]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yzshen1, 2016-08-19 22:41:27]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-19 22:41:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 02:19:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 02:20:01]

Exceeded global retry quota

[yzshen1, 2016-08-22 04:05:51]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-22 04:06:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 05:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 05:27:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yzshen1, 2016-08-22 06:10:31]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-22 06:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 07:48:08]

Description was changed from

==========
Mojo C++ bindings: extract code shared by different variants.

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).


BUG=632061
==========

to

==========
Mojo C++ bindings: extract code shared by different variants.

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).


BUG=632061
==========

[commit-bot: I haz the power, 2016-08-22 07:48:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-22 07:49:39]

Description was changed from

==========
Mojo C++ bindings: extract code shared by different variants.

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).


BUG=632061
==========

to

==========
Mojo C++ bindings: extract code shared by different variants.

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).

BUG=632061

Committed: https://crrev.com/f0a39ef09ff38dd10fe170c9bad90b7e3d0f4ed1
Cr-Commit-Position: refs/heads/master@{#413415}
==========

[commit-bot: I haz the power, 2016-08-22 07:49:40]

Patchset 6 (id:??) landed as
https://crrev.com/f0a39ef09ff38dd10fe170c9bad90b7e3d0f4ed1
Cr-Commit-Position: refs/heads/master@{#413415}