mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl - Issue 2247083003: Mojo C++ bindings: extract code shared by different variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

Issue 2247083003: Mojo C++ bindings: extract code shared by different variants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl ('K') | « mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

index 367be6d67b56957b5d05af9122f2214f2883e6ef..a50a585c09a89a0c813bd1cddfb7e4b52f27a405 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

@@ -66,7 +66,7 @@

{#- Validates the specified field, which is supposed to be an enum.

This macro is expanded by the Validate() method. #}

{%- macro validate_enum(field, field_expr) %}

- if (!{{field.kind|get_qualified_name_for_kind(internal=True)}}

+ if (!{{field.kind|get_qualified_name_for_kind(internal=True,flatten_nested_kind=True)}}

::Validate({{field_expr}}, validation_context))

return false;

{%- endmacro %}