Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2247013002: Remove SoftwareOutputDeviceMus. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mus-use-gpu-compositor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SoftwareOutputDeviceMus. chrome should always use the compositor in the mus-gpu process. So SoftwareOutputDeviceMus is no longer necessary. BUG=none TBR=ben@ for trivial content/browser/BUILD.gn change Committed: https://crrev.com/de96c7a718d997472d1bb6e009893dab12055775 Cr-Commit-Position: refs/heads/master@{#412076}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -108 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +2 lines, -3 lines 2 comments Download
D content/browser/compositor/software_output_device_mus.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/compositor/software_output_device_mus.cc View 1 chunk +0 lines, -67 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
sadrul
4 years, 4 months ago (2016-08-15 18:06:10 UTC) #4
danakj
LGTM https://codereview.chromium.org/2247013002/diff/1/content/browser/compositor/gpu_process_transport_factory.cc File content/browser/compositor/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/2247013002/diff/1/content/browser/compositor/gpu_process_transport_factory.cc#newcode202 content/browser/compositor/gpu_process_transport_factory.cc:202: #if defined(USE_AURA) Or maybe just remove this whole ...
4 years, 4 months ago (2016-08-15 18:32:58 UTC) #5
sadrul
+ben@ for trivial content/browser/BUILD.gn update. (will TBR) https://codereview.chromium.org/2247013002/diff/1/content/browser/compositor/gpu_process_transport_factory.cc File content/browser/compositor/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/2247013002/diff/1/content/browser/compositor/gpu_process_transport_factory.cc#newcode202 content/browser/compositor/gpu_process_transport_factory.cc:202: #if defined(USE_AURA) ...
4 years, 4 months ago (2016-08-15 22:39:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247013002/1
4 years, 4 months ago (2016-08-15 22:40:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 22:44:24 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 22:50:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de96c7a718d997472d1bb6e009893dab12055775
Cr-Commit-Position: refs/heads/master@{#412076}

Powered by Google App Engine
This is Rietveld 408576698