services/ui: Move BitmapUploader into mus_demo.

services/ui: Move BitmapUploader into mus_demo.

Only mus_demo uses BitmapUploader. So move it out of the client-lib into
mus_demo.

BUG=none

Committed: https://crrev.com/adffa41e80865d13d6a55503cc2cae8201162f42
Cr-Commit-Position: refs/heads/master@{#412109}

[sadrul, 2016-08-15 18:14:02]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 18:14:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-15 18:16:02]

sadrul@chromium.org changed reviewers:
+ fsamuel@chromium.org, sky@chromium.org

[sadrul, 2016-08-15 18:16:03]

I am still doing the weird thing with target visibility in BUILD.gn to keep
ui::GLES2Context in the mus internal API, but expose it just for BitmapUploader
in mus_demo (because I still think 'normal' clients shouldn't need to directly
use it). Let me know if this sounds OK to you.

[commit-bot: I haz the power, 2016-08-15 19:30:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 19:30:51]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-15 19:36:41]

I'm still a bit bothered by having to special case the demo. What's so bad about
moving gles2_context.h into public? Why do we think mus_demo is different than
what others may want to do?

[sadrul, 2016-08-15 20:39:45]

On 2016/08/15 19:36:41, sky wrote:
> I'm still a bit bothered by having to special case the demo. What's so bad
about
> moving gles2_context.h into public? Why do we think mus_demo is different than
> what others may want to do?

For the short term, I want to enforce that all mus clients are using cc (and so
ui::OutputSurface). This is mostly so there's only one way of doing things, and
to reduce the API surface mus supports right now. In the future at some point,
it may make sense to expose more things to clients. I think mus_demo more as a
test than a real mus client. So exposing the internal API to mus_demo seems OK
to me.

I do not feel very strongly about it, but I do wanted to share this viewpoint.
:)

[sky, 2016-08-15 20:45:25]

Ok, LGTM

[sadrul, 2016-08-16 00:00:47]

Cool, thanks!

[sadrul, 2016-08-16 00:00:51]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-08-16 00:01:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 00:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 00:08:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-08-16 00:12:41]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[sadrul, 2016-08-16 00:12:41]

+piman@ for DEPS addition on gpu/GLES2 from mus-demo

[piman, 2016-08-16 00:13:58]

lgtm

[sadrul, 2016-08-16 00:14:40]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-08-16 00:15:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 00:20:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-16 00:22:24]

Description was changed from

==========
services/ui: Move BitmapUploader into mus_demo.

Only mus_demo uses BitmapUploader. So move it out of the client-lib into
mus_demo.

BUG=none
==========

to

==========
services/ui: Move BitmapUploader into mus_demo.

Only mus_demo uses BitmapUploader. So move it out of the client-lib into
mus_demo.

BUG=none

Committed: https://crrev.com/adffa41e80865d13d6a55503cc2cae8201162f42
Cr-Commit-Position: refs/heads/master@{#412109}
==========

[commit-bot: I haz the power, 2016-08-16 00:22:25]

Patchset 1 (id:??) landed as
https://crrev.com/adffa41e80865d13d6a55503cc2cae8201162f42
Cr-Commit-Position: refs/heads/master@{#412109}