Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2247023002: services/ui: Move BitmapUploader into mus_demo. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
Reviewers:
Fady Samuel, sky, piman
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@rm-software-output-device-mus
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Move BitmapUploader into mus_demo. Only mus_demo uses BitmapUploader. So move it out of the client-lib into mus_demo. BUG=none Committed: https://crrev.com/adffa41e80865d13d6a55503cc2cae8201162f42 Cr-Commit-Position: refs/heads/master@{#412109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -297 lines) Patch
M services/ui/demo/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M services/ui/demo/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + services/ui/demo/bitmap_uploader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/ui/demo/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
D services/ui/public/cpp/bitmap_uploader.h View 1 chunk +0 lines, -86 lines 0 comments Download
D services/ui/public/cpp/bitmap_uploader.cc View 1 chunk +0 lines, -203 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (10 generated)
sadrul
I am still doing the weird thing with target visibility in BUILD.gn to keep ui::GLES2Context ...
4 years, 4 months ago (2016-08-15 18:16:03 UTC) #4
sky
I'm still a bit bothered by having to special case the demo. What's so bad ...
4 years, 4 months ago (2016-08-15 19:36:41 UTC) #7
sadrul
On 2016/08/15 19:36:41, sky wrote: > I'm still a bit bothered by having to special ...
4 years, 4 months ago (2016-08-15 20:39:45 UTC) #8
sky
Ok, LGTM
4 years, 4 months ago (2016-08-15 20:45:25 UTC) #9
sadrul
Cool, thanks!
4 years, 4 months ago (2016-08-16 00:00:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247023002/1
4 years, 4 months ago (2016-08-16 00:01:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/238490)
4 years, 4 months ago (2016-08-16 00:08:55 UTC) #14
sadrul
+piman@ for DEPS addition on gpu/GLES2 from mus-demo
4 years, 4 months ago (2016-08-16 00:12:41 UTC) #16
piman
lgtm
4 years, 4 months ago (2016-08-16 00:13:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247023002/1
4 years, 4 months ago (2016-08-16 00:15:25 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 00:20:08 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 00:22:25 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adffa41e80865d13d6a55503cc2cae8201162f42
Cr-Commit-Position: refs/heads/master@{#412109}

Powered by Google App Engine
This is Rietveld 408576698