Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2251753002: Merge TextCheckingHelper into SpellChecker Part 5 (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CleanupIncludesInTCH
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge TextCheckingHelper into SpellChecker Part 5 This patch renames TextCheckingHelper.h/cpp to TextCheckingParagraph.h/cpp because the class TextCheckingHelper no longer exists. This patch is the final part of a series of patches: - Part 1: http://crrev.com/2246053003 - Part 2: http://crrev.com/2253523002 - Part 3: http://crrev.com/2247273002 - part 4: http://crrev.com/2246923004 BUG=619452 TEST=n/a; no behavior change Committed: https://crrev.com/6bdbfe4114fc567476b5f87ba547627ede13b308 Cr-Commit-Position: refs/heads/master@{#412432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -268 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 1 chunk +0 lines, -181 lines 0 comments Download
A + third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-17 02:10:45 UTC) #6
tkent
lgtm
4 years, 4 months ago (2016-08-17 02:28:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251753002/1
4 years, 4 months ago (2016-08-17 02:33:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 02:38:28 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 02:41:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bdbfe4114fc567476b5f87ba547627ede13b308
Cr-Commit-Position: refs/heads/master@{#412432}

Powered by Google App Engine
This is Rietveld 408576698