Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Issue 2246383002: Remove unused Font argument from InlineTextBox::constructTextRun (Closed)

Created:
4 years, 4 months ago by kojii
Modified:
4 years, 4 months ago
Reviewers:
eae, rune
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dshwang, eae+blinkwatch, jchaffraix+rendering, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@combine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused Font argument from InlineTextBox::constructTextRun The "const Font& font" argument is not used in InlineTextBox::constructTextRun and all its variants. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/9082db4d429c51cd688a33a98f5d31cc7fb613e5 Cr-Commit-Position: refs/heads/master@{#412478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
kojii
PTAL.
4 years, 4 months ago (2016-08-16 06:00:11 UTC) #8
rune
drive-by lgtm
4 years, 4 months ago (2016-08-16 08:13:52 UTC) #11
eae
Nice, LGTM!
4 years, 4 months ago (2016-08-16 14:44:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246383002/1
4 years, 4 months ago (2016-08-17 06:01:43 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 08:56:49 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 08:58:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9082db4d429c51cd688a33a98f5d31cc7fb613e5
Cr-Commit-Position: refs/heads/master@{#412478}

Powered by Google App Engine
This is Rietveld 408576698