third_party/WebKit/Source/core/layout/line/InlineTextBox.h - Issue 2246383002: Remove unused Font argument from InlineTextBox::constructTextRun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

Issue 2246383002: Remove unused Font argument from InlineTextBox::constructTextRun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@combine

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

index 8e3b19f838dc47650b897a9d97528599b64cdd13..4eed61844e1fe9c23f5df65eb14dbaf004d9ddb8 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.h

@@ -89,8 +89,8 @@ public:

LayoutUnit logicalBottomVisualOverflow() const { return logicalOverflowRect().maxY(); }

// charactersWithHyphen, if provided, must not be destroyed before the TextRun.

- TextRun constructTextRun(const ComputedStyle&, const Font&, StringBuilder* charactersWithHyphen = nullptr) const;

- TextRun constructTextRun(const ComputedStyle&, const Font&, StringView, int maximumLength, StringBuilder* charactersWithHyphen = nullptr) const;

+ TextRun constructTextRun(const ComputedStyle&, StringBuilder* charactersWithHyphen = nullptr) const;

+ TextRun constructTextRun(const ComputedStyle&, StringView, int maximumLength, StringBuilder* charactersWithHyphen = nullptr) const;

#ifndef NDEBUG

void showBox(int = 0) const override;

@@ -101,7 +101,7 @@ public:

String text() const;

public:

- TextRun constructTextRunForInspector(const ComputedStyle&, const Font&) const;

+ TextRun constructTextRunForInspector(const ComputedStyle&) const;

LayoutRect calculateBoundaries() const override { return LayoutRect(x(), y(), width(), height()); }

virtual LayoutRect localSelectionRect(int startPos, int endPos) const;