Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2248803002: Fix when there are justification opportunities inside text-combine-upright (Closed)

Created:
4 years, 4 months ago by kojii
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix when there are justification opportunities inside text-combine-upright This patch fixes justification spacing to not to apply inside a text-combine-upright when it has justification opportunities. The spec[1] defines that "For...spacing, the resulting composition is treated as a single glyph". [1] https://drafts.csswg.org/css-writing-modes-3/#text-combine-layout BUG=607404 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/211db48591bc2bb3ff91d250c263606f1e3ae333 Cr-Commit-Position: refs/heads/master@{#412437}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/fast/writing-mode/text-combine-justify.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/writing-mode/text-combine-justify-expected.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 3 chunks +22 lines, -9 lines 1 comment Download
M third_party/WebKit/Source/platform/text/TextRun.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
kojii
PTAL. https://codereview.chromium.org/2248803002/diff/20001/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right): https://codereview.chromium.org/2248803002/diff/20001/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp#newcode117 third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:117: This block is simply a move from line ...
4 years, 4 months ago (2016-08-16 05:59:56 UTC) #10
eae
LGTM
4 years, 4 months ago (2016-08-16 14:45:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248803002/20001
4 years, 4 months ago (2016-08-16 14:46:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/274458)
4 years, 4 months ago (2016-08-16 19:22:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248803002/20001
4 years, 4 months ago (2016-08-17 01:18:59 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 03:04:06 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 03:06:16 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/211db48591bc2bb3ff91d250c263606f1e3ae333
Cr-Commit-Position: refs/heads/master@{#412437}

Powered by Google App Engine
This is Rietveld 408576698