include only stuff you need, part 1: ast.h, ast-value-factory.h.

include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=v8:5294
Committed: https://crrev.com/0a0285bf5db61009c0f621aeecac8db64c0a2616
Cr-Commit-Position: refs/heads/master@{#38708}

[marja, 2016-08-17 10:59:25]

Description was changed from

==========
include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=
==========

to

==========
include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=v8:5294
==========

[marja, 2016-08-17 11:01:51]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 11:01:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-08-17 11:23:16]

Patchset #3 (id:40001) has been deleted

[marja, 2016-08-17 11:23:58]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 11:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 11:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 11:47:52]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-08-17 12:01:53]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2016-08-17 12:01:54]

lgtm

[marja, 2016-08-17 12:07:29]

marja@chromium.org changed reviewers:
- verwaest@chromium.org

[marja, 2016-08-17 12:07:30]

https://codereview.chromium.org/2246203005/diff/20001/src/asmjs/asm-js.cc
File src/asmjs/asm-js.cc (left):

https://codereview.chromium.org/2246203005/diff/20001/src/asmjs/asm-js.cc#old...
src/asmjs/asm-js.cc:12: #include "src/ast/ast.h"
Not that super useful since this file will still get them via parser.h. But
afaics it doesn't need them. (Based on quick manual inspection.)

https://codereview.chromium.org/2246203005/diff/20001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/2246203005/diff/20001/src/compiler.h#newcode16
src/compiler.h:16: #include "src/objects-inl.h"
Note that ast.h used to include objects-inl.h via ast-value-factory.h -> api.h
-> objects-inl.h. So I'm not adding an extra link to it.

https://codereview.chromium.org/2246203005/diff/20001/src/frames.cc
File src/frames.cc (left):

https://codereview.chromium.org/2246203005/diff/20001/src/frames.cc#oldcode14
src/frames.cc:14: #include "src/full-codegen/full-codegen.h"
Ditto; here we'll get ast.h via full-codegen.h anyway :(

[marja, 2016-08-17 12:15:53]

marja@chromium.org changed reviewers:
+ rossberg@chromium.org, verwaest@chromium.org

[marja, 2016-08-17 12:15:53]

rossberg, you're an owner of   src/asmjs/asm-js.cc, could you review?

(Background: when I touch ast-value-factory.h, the whole world gets rebuilt and
that's annoying. This is the beginning of an attempt to fix that. I'm not sure
if it'll work.)

[rossberg, 2016-08-18 09:48:46]

On 2016/08/17 12:15:53, marja wrote:
> rossberg, you're an owner of   src/asmjs/asm-js.cc, could you review?
> 
> (Background: when I touch ast-value-factory.h, the whole world gets rebuilt
and
> that's annoying. This is the beginning of an attempt to fix that. I'm not sure
> if it'll work.)

Didn't even know I'm an owner of the asmjs dir, but change LGTM.

[marja, 2016-08-18 10:24:12]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-08-18 10:24:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 10:26:22]

Description was changed from

==========
include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=v8:5294
==========

to

==========
include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=v8:5294
==========

[commit-bot: I haz the power, 2016-08-18 10:26:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 10:26:41]

Description was changed from

==========
include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=v8:5294
==========

to

==========
include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=v8:5294

Committed: https://crrev.com/0a0285bf5db61009c0f621aeecac8db64c0a2616
Cr-Commit-Position: refs/heads/master@{#38708}
==========

[commit-bot: I haz the power, 2016-08-18 10:26:42]

Patchset 2 (id:??) landed as
https://crrev.com/0a0285bf5db61009c0f621aeecac8db64c0a2616
Cr-Commit-Position: refs/heads/master@{#38708}