Use EphemeralRange instead of Range* in DocumentMarkerController class.

Use EphemeralRange instead of Range* in DocumentMarkerController class.

No behavior changes.

BUG=388681
Committed: https://crrev.com/1ca795d42eaa49b6e49bcbcc33338663a922265f
Cr-Commit-Position: refs/heads/master@{#413384}

[Andrey Kraynov, 2016-08-15 22:45:48]

iceman@yandex-team.ru changed reviewers:
+ yosin@chromium.org

[Andrey Kraynov, 2016-08-15 22:45:49]

Hi!

Quite a long time ago there was my CL
https://codereview.chromium.org/1409073004, where I tried to use
|EphemeralRange| in |Editor| class.
Recently I've rebased it on latest master and decided to continue my work
(better late than never, I hope).
It seems, that could be better to split it into few parts.
Here are changes for DocumentMarkerController, as you suggested in last comment,
https://codereview.chromium.org/1409073004/#msg13.
I used |EphemeralRange| to avoid usage of the |Range| class, but I have a
question about that. In the comment you mentioned, that it is possible to use
range in composed tree (or in flat tree as I understand). But I see that all
changes for the bug crbug.com/388681 were made with |EphemeralRange|, but not
with |EphemeralRangeInFlatTree|. Is that OK? What will be better for
|DocumentMarkerController| class, how do you think?

Hope that you will find a time to take a look at this CL.
Thanks in advance!

https://codereview.chromium.org/2246143004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2246143004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:62:
class TraversalRangeImpl : public TraversalRange<Iterator> {
This is not required for this CL to work, but I see that iteration over a range
could be simplified a bit.
If that looks good to you, I can move it to some header and change other places
using my new |inRange| helper.

[yosin_UTC9, 2016-08-16 02:02:54]

https://codereview.chromium.org/2246143004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2246143004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:62:
class TraversalRangeImpl : public TraversalRange<Iterator> {
On 2016/08/15 at 22:45:49, Andrey Kraynov wrote:
> This is not required for this CL to work, but I see that iteration over a
range could be simplified a bit.
> If that looks good to you, I can move it to some header and change other
places using my new |inRange| helper.

I love this! (^_^)b
Do we want to put this to "EphemeralRange.h"?
Since, "EphmeralRange.h" already has included "NodeTraversal.h"

Let's have a another CL for this with gTest.

[Andrey Kraynov, 2016-08-19 09:03:33]

On 2016/08/16 02:02:54, Yosi_UTC9 wrote:
> Let's have a another CL for this with gTest.

I've rebased on master after my CL with new range iterators was landed.
Could you take another look, please?

[yosin_UTC9, 2016-08-19 09:21:17]

lgtm

Thanks for introducing |EphmeralRange::nodes()|!

[Andrey Kraynov, 2016-08-19 10:07:03]

iceman@yandex-team.ru changed reviewers:
+ tkent@chromium.org

[Andrey Kraynov, 2016-08-19 10:07:03]

+ tkent@ for OWNERS review.

[tkent, 2016-08-21 23:37:03]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-08-21 23:37:04]

lgtm

[commit-bot: I haz the power, 2016-08-21 23:37:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 01:43:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 01:45:32]

Description was changed from

==========
Use EphemeralRange instead of Range* in DocumentMarkerController class.

No behavior changes.

BUG=388681
==========

to

==========
Use EphemeralRange instead of Range* in DocumentMarkerController class.

No behavior changes.

BUG=388681

Committed: https://crrev.com/1ca795d42eaa49b6e49bcbcc33338663a922265f
Cr-Commit-Position: refs/heads/master@{#413384}
==========

[commit-bot: I haz the power, 2016-08-22 01:45:33]

Patchset 2 (id:??) landed as
https://crrev.com/1ca795d42eaa49b6e49bcbcc33338663a922265f
Cr-Commit-Position: refs/heads/master@{#413384}