Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: third_party/WebKit/Source/web/TextFinder.cpp

Issue 2246143004: Use EphemeralRange instead of Range* in DocumentMarkerController class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on master Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/TextFinder.cpp
diff --git a/third_party/WebKit/Source/web/TextFinder.cpp b/third_party/WebKit/Source/web/TextFinder.cpp
index bd929e8eb8054aa84df31d390fe1f2ea77b4c60b..ceeadf3169d765159d7f38b9941c047527427e99 100644
--- a/third_party/WebKit/Source/web/TextFinder.cpp
+++ b/third_party/WebKit/Source/web/TextFinder.cpp
@@ -366,7 +366,7 @@ void TextFinder::scopeStringMatches(int identifier, const WebString& searchText,
identifier);
}
- ownerFrame().frame()->document()->markers().addTextMatchMarker(resultRange, foundActiveMatch);
+ ownerFrame().frame()->document()->markers().addTextMatchMarker(EphemeralRange(resultRange), foundActiveMatch);
m_findMatchesCache.append(FindMatch(resultRange, m_lastMatchCount + matchCount));
@@ -662,7 +662,7 @@ bool TextFinder::setMarkerActive(Range* range, bool active)
{
if (!range || range->collapsed())
return false;
- return ownerFrame().frame()->document()->markers().setMarkersActive(range, active);
+ return ownerFrame().frame()->document()->markers().setMarkersActive(EphemeralRange(range), active);
}
void TextFinder::unmarkAllTextMatches()
« no previous file with comments | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698