third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp - Issue 2246143004: Use EphemeralRange instead of Range* in DocumentMarkerController class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2246143004: Use EphemeralRange instead of Range* in DocumentMarkerController class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on master Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

index 5611a89967bdb911bafee30ba9a6fee190df6cf1..d8ea19ddabcefdb9b5c1ce04c38be6ad5d4f8037 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

@@ -252,7 +252,7 @@ TEST_F(DocumentMarkerControllerTest, SetMarkerActiveTest)

EphemeralRange ephemeralRange = EphemeralRange::rangeOfContents(*bElement);

Position startBElement = toPositionInDOMTree(ephemeralRange.startPosition());

Position endBElement = toPositionInDOMTree(ephemeralRange.endPosition());

- Range* range = Range::create(document(), startBElement, endBElement);

+ const EphemeralRange range(startBElement, endBElement);

// Try to make active a marker that doesn't exist.

EXPECT_FALSE(markerController().setMarkersActive(range, true));