Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2245803002: Remove BidirectionalStream.Builder.disableAutoFlush (Closed)

Created:
4 years, 4 months ago by xunjieli
Modified:
4 years, 4 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove BidirectionalStream.Builder.disableAutoFlush This CL removes BidirectionalStream.Builder.disableAutoFlush to simply the API. BUG=637383 Committed: https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c Cr-Commit-Position: refs/heads/master@{#412821}

Patch Set 1 : self review #

Total comments: 1

Messages

Total messages: 10 (4 generated)
xunjieli
4 years, 4 months ago (2016-08-12 20:49:00 UTC) #3
kapishnikov
Helen, sorry for the late review. The change looks great. LGTM! https://codereview.chromium.org/2245803002/diff/20001/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java File components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java (right): ...
4 years, 4 months ago (2016-08-17 22:30:56 UTC) #4
xunjieli
Thanks!
4 years, 4 months ago (2016-08-18 13:21:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2245803002/20001
4 years, 4 months ago (2016-08-18 13:21:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-18 14:07:48 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 14:09:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb5b665ffd1ebf35811d48c595bd1396ed8b074c
Cr-Commit-Position: refs/heads/master@{#412821}

Powered by Google App Engine
This is Rietveld 408576698