Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

Issue 2245803002: Remove BidirectionalStream.Builder.disableAutoFlush (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
diff --git a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
index 40dcec95fbbd528bf98df0c52f45a46e40a7e8d8..e64361998cd9c61aff6aa5174e0bbc35792d1ae7 100644
--- a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
+++ b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
@@ -48,8 +48,6 @@ public abstract class BidirectionalStream {
// Priority of the stream. Default is medium.
@StreamPriority private int mPriority = STREAM_PRIORITY_MEDIUM;
- // TODO(xunjieli): Remove mDisableAutoFlush and make flush() required as part of th API.
- private boolean mDisableAutoFlush;
private boolean mDelayRequestHeadersUntilFirstFlush;
/**
@@ -164,19 +162,6 @@ public abstract class BidirectionalStream {
}
/**
- * Disables or enables auto flush. By default, data is flushed after
- * every {@link #write write()}. If the auto flush is disabled, the
- * client should explicitly call {@link #flush flush()} to flush the data.
- *
- * @param disableAutoFlush if true, auto flush will be disabled.
- * @return the builder to facilitate chaining.
- */
- public Builder disableAutoFlush(boolean disableAutoFlush) {
- mDisableAutoFlush = disableAutoFlush;
- return this;
- }
-
- /**
* Delays sending request headers until {@link BidirectionalStream#flush()}
* is called. This flag is currently only respected when QUIC is negotiated.
* When true, QUIC will send request header frame along with data frame(s)
@@ -203,8 +188,7 @@ public abstract class BidirectionalStream {
@SuppressLint("WrongConstant") // TODO(jbudorick): Remove this after rolling to the N SDK.
public BidirectionalStream build() {
return mCronetEngine.createBidirectionalStream(mUrl, mCallback, mExecutor, mHttpMethod,
- mRequestHeaders, mPriority, mDisableAutoFlush,
- mDelayRequestHeadersUntilFirstFlush);
+ mRequestHeaders, mPriority, mDelayRequestHeadersUntilFirstFlush);
}
}

Powered by Google App Engine
This is Rietveld 408576698