Remove BidirectionalStream.Builder.disableAutoFlush

components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.annotation.SuppressLint;
 import android.support.annotation.IntDef;
 
 import java.lang.annotation.Retention;
@@ skipping 30 matching lines @@
         private final Executor mExecutor;
         // List of request headers, stored as header field name and value pairs.
         private final ArrayList<Map.Entry<String, String>> mRequestHeaders =
                 new ArrayList<Map.Entry<String, String>>();
 
         // HTTP method for the request. Default to POST.
         private String mHttpMethod = "POST";
         // Priority of the stream. Default is medium.
         @StreamPriority private int mPriority = STREAM_PRIORITY_MEDIUM;
 
-        // TODO(xunjieli): Remove mDisableAutoFlush and make flush() required as part of th API.
-        private boolean mDisableAutoFlush;
         private boolean mDelayRequestHeadersUntilFirstFlush;
 
         /**
          * Creates a builder for {@link BidirectionalStream} objects. All callbacks for
          * generated {@code BidirectionalStream} objects will be invoked on
          * {@code executor}. {@code executor} must not run tasks on the
          * current thread, otherwise the networking operations may block and exceptions
          * may be thrown at shutdown time.
          *
          * @param url the URL for the generated stream
@@ skipping 94 matching lines @@
          * @param priority priority of the stream which should be one of the
          *         {@link #STREAM_PRIORITY_IDLE STREAM_PRIORITY_*} values.
          * @return the builder to facilitate chaining.
          */
         public Builder setPriority(@StreamPriority int priority) {
             mPriority = priority;
             return this;
         }
 
         /**
-         * Disables or enables auto flush. By default, data is flushed after
-         * every {@link #write write()}. If the auto flush is disabled, the
-         * client should explicitly call {@link #flush flush()} to flush the data.
-         *
-         * @param disableAutoFlush if true, auto flush will be disabled.
-         * @return the builder to facilitate chaining.
-         */
-        public Builder disableAutoFlush(boolean disableAutoFlush) {
-            mDisableAutoFlush = disableAutoFlush;
-            return this;
-        }
-
-        /**
          * Delays sending request headers until {@link BidirectionalStream#flush()}
          * is called. This flag is currently only respected when QUIC is negotiated.
          * When true, QUIC will send request header frame along with data frame(s)
          * as a single packet when possible.
          *
          * @param delayRequestHeadersUntilFirstFlush if true, sending request headers will
          *         be delayed until flush() is called.
          * @return the builder to facilitate chaining.
          */
         public Builder delayRequestHeadersUntilFirstFlush(
                 boolean delayRequestHeadersUntilFirstFlush) {
             mDelayRequestHeadersUntilFirstFlush = delayRequestHeadersUntilFirstFlush;
             return this;
         }
 
         /**
          * Creates a {@link BidirectionalStream} using configuration from this
          * {@link Builder}. The returned {@code BidirectionalStream} can then be started
          * by calling {@link BidirectionalStream#start}.
          *
          * @return constructed {@link BidirectionalStream} using configuration from
          *         this {@link Builder}
          */
         @SuppressLint("WrongConstant") // TODO(jbudorick): Remove this after rolling to the N SDK.
         public BidirectionalStream build() {
             return mCronetEngine.createBidirectionalStream(mUrl, mCallback, mExecutor, mHttpMethod,
-                    mRequestHeaders, mPriority, mDisableAutoFlush,
-                    mDelayRequestHeadersUntilFirstFlush);
+                    mRequestHeaders, mPriority, mDelayRequestHeadersUntilFirstFlush);
         }
     }
 
     /**
      * Callback class used to receive callbacks from a {@link BidirectionalStream}.
      */
     public abstract static class Callback {
         /**
          * Invoked when the stream is ready for reading and writing.
          * Consumer may call {@link BidirectionalStream#read read()} to start reading data.
@@ skipping 183 matching lines @@
     /**
      * Returns {@code true} if the stream was successfully started and is now
      * done (succeeded, canceled, or failed).
      *
      * @return {@code true} if the stream was successfully started and is now
      *         done (completed, canceled, or failed), otherwise returns {@code false}
      *         to indicate stream is not yet started or is in progress.
      */
     public abstract boolean isDone();
 }