Clean up defensive TabManager handling

chrome/browser/memory/tab_manager_browsertest.cc

Index: chrome/browser/memory/tab_manager_browsertest.cc
diff --git a/chrome/browser/memory/tab_manager_browsertest.cc b/chrome/browser/memory/tab_manager_browsertest.cc
index 8813ee2be3f4765826904073b5c0078a1e1dc6fb..3742772cef48640b5589272656479983a78401b1 100644
--- a/chrome/browser/memory/tab_manager_browsertest.cc
+++ b/chrome/browser/memory/tab_manager_browsertest.cc
@@ -48,7 +48,6 @@ class TabManagerTest : public InProcessBrowserTest {
 IN_PROC_BROWSER_TEST_F(TabManagerTest, TabManagerBasics) {
   using content::WindowedNotificationObserver;
   TabManager* tab_manager = g_browser_process->GetTabManager();
-  ASSERT_TRUE(tab_manager);

[Devlin, 2016/08/16 16:10:51]

Suggestion: could put this at the end of SetUpOnMainThread() or something, so
that it applies to all tests without the extra bloat?

[Anderson Silva, 2016/08/16 17:26:12]

Acknowledged.

   EXPECT_FALSE(tab_manager->recent_tab_discard());
 
   // Disable the protection of recent tabs.
@@ -188,7 +187,6 @@ IN_PROC_BROWSER_TEST_F(TabManagerTest, TabManagerBasics) {
 // discard upon |MEMORY_PRESSURE_LEVEL_CRITICAL| event.
 IN_PROC_BROWSER_TEST_F(TabManagerTest, OomPressureListener) {
   TabManager* tab_manager = g_browser_process->GetTabManager();
-  ASSERT_TRUE(tab_manager);
 
   // Disable the protection of recent tabs.
   tab_manager->minimum_protection_time_ = base::TimeDelta::FromMinutes(0);
@@ -238,7 +236,6 @@ IN_PROC_BROWSER_TEST_F(TabManagerTest, OomPressureListener) {
 
 IN_PROC_BROWSER_TEST_F(TabManagerTest, InvalidOrEmptyURL) {
   TabManager* tab_manager = g_browser_process->GetTabManager();
-  ASSERT_TRUE(tab_manager);
 
   // Disable the protection of recent tabs.
   tab_manager->minimum_protection_time_ = base::TimeDelta::FromMinutes(0);
@@ -274,7 +271,6 @@ IN_PROC_BROWSER_TEST_F(TabManagerTest, InvalidOrEmptyURL) {
 // Makes sure that PDF pages are protected.
 IN_PROC_BROWSER_TEST_F(TabManagerTest, ProtectPDFPages) {
   TabManager* tab_manager = g_browser_process->GetTabManager();
-  ASSERT_TRUE(tab_manager);
 
   // Start the embedded test server so we can get served the required PDF page.
   ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
@@ -303,7 +299,6 @@ IN_PROC_BROWSER_TEST_F(TabManagerTest, ProtectRecentlyUsedTabs) {
   // constant (as of now, it gets set through variations).
   const int kProtectionTime = 5;
   TabManager* tab_manager = g_browser_process->GetTabManager();
-  ASSERT_TRUE(tab_manager);
 
   base::SimpleTestTickClock test_clock_;
   tab_manager->set_test_tick_clock(&test_clock_);
@@ -357,7 +352,6 @@ IN_PROC_BROWSER_TEST_F(TabManagerTest, ProtectRecentlyUsedTabs) {
 // Makes sure that tabs using media devices are protected.
 IN_PROC_BROWSER_TEST_F(TabManagerTest, ProtectVideoTabs) {
   TabManager* tab_manager = g_browser_process->GetTabManager();
-  ASSERT_TRUE(tab_manager);
 
   // Disable the protection of recent tabs.
   tab_manager->minimum_protection_time_ = base::TimeDelta::FromMinutes(0);