chrome/browser/extensions/api/tabs/tabs_test.cc - Issue 2245203002: Clean up defensive TabManager handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 2245203002: Clean up defensive TabManager handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_test.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc

index 6927d6f7b4b71a887347a91a4b8dc18191f60d5e..d83797e5c2a153dda404008a28cfe037739b6e35 100644

--- a/chrome/browser/extensions/api/tabs/tabs_test.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_test.cc

@@ -1317,7 +1317,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, ExecuteScriptOnDevTools) {

// TODO(georgesak): change this browsertest to an unittest.

IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DiscardedProperty) {

- ASSERT_TRUE(g_browser_process && g_browser_process->GetTabManager());

Devlin 2016/08/16 16:10:50 This seems reasonable to keep, since it helps ensu

Anderson Silva 2016/08/16 17:26:12 Done.

memory::TabManager* tab_manager = g_browser_process->GetTabManager();

// Create two aditional tabs.