chrome/browser/memory/tab_manager.cc - Issue 2245203002: Clean up defensive TabManager handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory/tab_manager.cc

Issue 2245203002: Clean up defensive TabManager handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory/tab_manager.cc

diff --git a/chrome/browser/memory/tab_manager.cc b/chrome/browser/memory/tab_manager.cc

index a99e6abdc048bd79f91e73bd4fe68c6b523fc5f1..1bf1f1ead5790ea2a57c917997c06b029fb6a515 100644

--- a/chrome/browser/memory/tab_manager.cc

+++ b/chrome/browser/memory/tab_manager.cc

@@ -483,11 +483,9 @@ void TabManager::OnAutoDiscardableStateChange(content::WebContents* contents,

// static

void TabManager::PurgeMemoryAndDiscardTab() {

- if (g_browser_process && g_browser_process->GetTabManager()) {

- TabManager* manager = g_browser_process->GetTabManager();

- manager->PurgeBrowserMemory();

- manager->DiscardTab();

- }

+ TabManager* manager = g_browser_process->GetTabManager();

+ manager->PurgeBrowserMemory();

+ manager->DiscardTab();

}

// static