Clean up defensive TabManager handling

TabManager should be defined in all cases, so we no longer
need to defensively check whether or not it is null.

BUG=630645
Committed: https://crrev.com/23ac43bec939cc186cdb0f27a73ff862671c7a0e
Cr-Commit-Position: refs/heads/master@{#412323}

[Anderson Silva, 2016-08-15 21:16:55]

The CQ bit was checked by andersoncss@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 21:17:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Anderson Silva, 2016-08-15 21:18:54]

Description was changed from

==========
tab_manager is never false

BUG=630645
==========

to

==========
tab_manager is never false

BUG=630645
==========

[Anderson Silva, 2016-08-15 21:18:54]

andersoncss@google.com changed reviewers:
+ chrisha@chromium.org, georgesak@chromium.org

[Anderson Silva, 2016-08-15 21:19:03]

ptal

[Georges Khalil, 2016-08-15 21:43:53]

lgtm

[commit-bot: I haz the power, 2016-08-15 21:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 21:58:37]

Dry run: This issue passed the CQ dry run.

[Anderson Silva, 2016-08-16 15:35:14]

The CQ bit was checked by andersoncss@google.com

[commit-bot: I haz the power, 2016-08-16 15:35:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 15:41:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Anderson Silva, 2016-08-16 15:45:09]

andersoncss@google.com changed reviewers:
+ rdevlin.cronin@chromium.org

[Anderson Silva, 2016-08-16 15:45:32]

ptal

[Devlin, 2016-08-16 16:10:51]

lgtm with nits.  Please also make the commit message a bit more clear.  e.g.

Clean up defensive TabManager handling

TabManager should be defined in all cases, so we no longer
need to defensively check whether or not it is null.

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tabs/tabs_test.cc (left):

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tabs/tabs_test.cc:1320:
ASSERT_TRUE(g_browser_process && g_browser_process->GetTabManager());
This seems reasonable to keep, since it helps ensure that what we know to be
true now remains true. :)

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/memory/tab_m...
File chrome/browser/memory/tab_manager_browsertest.cc (left):

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/memory/tab_m...
chrome/browser/memory/tab_manager_browsertest.cc:51: ASSERT_TRUE(tab_manager);
Suggestion: could put this at the end of SetUpOnMainThread() or something, so
that it applies to all tests without the extra bloat?

[Anderson Silva, 2016-08-16 16:15:11]

Description was changed from

==========
tab_manager is never false

BUG=630645
==========

to

==========
TabManager should be defined in all cases, so we no longer
need to defensively check whether or not it is null.

BUG=630645
==========

[Anderson Silva, 2016-08-16 17:25:12]

andersoncss@google.com changed reviewers:
+ sky@chromium.org

[Anderson Silva, 2016-08-16 17:26:13]

Hi sky, can you please take a look at this CL?
We need a owners review for the browser.cc file.
Thanks

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tabs/tabs_test.cc (left):

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tabs/tabs_test.cc:1320:
ASSERT_TRUE(g_browser_process && g_browser_process->GetTabManager());
On 2016/08/16 16:10:50, Devlin wrote:
> This seems reasonable to keep, since it helps ensure that what we know to be
> true now remains true. :)

Done.

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/memory/tab_m...
File chrome/browser/memory/tab_manager_browsertest.cc (left):

https://codereview.chromium.org/2245203002/diff/1/chrome/browser/memory/tab_m...
chrome/browser/memory/tab_manager_browsertest.cc:51: ASSERT_TRUE(tab_manager);
On 2016/08/16 16:10:51, Devlin wrote:
> Suggestion: could put this at the end of SetUpOnMainThread() or something, so
> that it applies to all tests without the extra bloat?

Acknowledged.

[sky, 2016-08-16 19:38:42]

LGTM

[Anderson Silva, 2016-08-16 19:39:31]

The CQ bit was checked by andersoncss@google.com

[Anderson Silva, 2016-08-16 19:39:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, georgesak@chromium.org
Link to the patchset: https://codereview.chromium.org/2245203002/#ps20001
(title: "nit")

[sky, 2016-08-16 19:39:35]

Actually, one question, are you sure android doesn't hit any of these code
paths?

[commit-bot: I haz the power, 2016-08-16 19:39:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 20:23:24]

Description was changed from

==========
TabManager should be defined in all cases, so we no longer
need to defensively check whether or not it is null.

BUG=630645
==========

to

==========
TabManager should be defined in all cases, so we no longer
need to defensively check whether or not it is null.

BUG=630645
==========

[commit-bot: I haz the power, 2016-08-16 20:23:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 20:26:24]

Description was changed from

==========
TabManager should be defined in all cases, so we no longer
need to defensively check whether or not it is null.

BUG=630645
==========

to

==========
TabManager should be defined in all cases, so we no longer
need to defensively check whether or not it is null.

BUG=630645

Committed: https://crrev.com/23ac43bec939cc186cdb0f27a73ff862671c7a0e
Cr-Commit-Position: refs/heads/master@{#412323}
==========

[commit-bot: I haz the power, 2016-08-16 20:26:25]

Patchset 2 (id:??) landed as
https://crrev.com/23ac43bec939cc186cdb0f27a73ff862671c7a0e
Cr-Commit-Position: refs/heads/master@{#412323}