chrome/browser/ui/browser.cc - Issue 2245203002: Clean up defensive TabManager handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 2245203002: Clean up defensive TabManager handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 4a25e9dded5bdd8ef632e313d192844cc1462b55..93b36dce53b8a81872b6653b810a61fcd9689e31 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1048,8 +1048,7 @@ void Browser::ActiveTabChanged(WebContents* old_contents,

// Discarded tabs always get reloaded.

// TODO(georgesak): Validate the usefulness of this. And if needed then move

// to TabManager.

- if (g_browser_process->GetTabManager() &&

- g_browser_process->GetTabManager()->IsTabDiscarded(new_contents))

+ if (g_browser_process->GetTabManager()->IsTabDiscarded(new_contents))

chrome::Reload(this, CURRENT_TAB);

// If we have any update pending, do it now.

« no previous file with comments | « chrome/browser/memory/tab_manager_observer_browsertest.cc ('k') | no next file » | no next file with comments »