chrome/browser/memory/tab_manager_observer_browsertest.cc - Issue 2245203002: Clean up defensive TabManager handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory/tab_manager_observer_browsertest.cc

Issue 2245203002: Clean up defensive TabManager handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory/tab_manager_observer_browsertest.cc

diff --git a/chrome/browser/memory/tab_manager_observer_browsertest.cc b/chrome/browser/memory/tab_manager_observer_browsertest.cc

index f105da9515cbe9a05c265aac6edd9b5d3108d020..a1d0d4abec292ea0bda885b6b430beab770fed8c 100644

--- a/chrome/browser/memory/tab_manager_observer_browsertest.cc

+++ b/chrome/browser/memory/tab_manager_observer_browsertest.cc

@@ -83,7 +83,6 @@ class MockTabManagerObserver : public TabManagerObserver {

IN_PROC_BROWSER_TEST_F(TabManagerObserverTest, OnDiscardStateChange) {

TabManager* tab_manager = g_browser_process->GetTabManager();

- ASSERT_TRUE(tab_manager);

auto* tsm = browser()->tab_strip_model();

set_tab_strip_model(tsm);

@@ -146,7 +145,6 @@ IN_PROC_BROWSER_TEST_F(TabManagerObserverTest, OnDiscardStateChange) {

IN_PROC_BROWSER_TEST_F(TabManagerObserverTest, OnAutoDiscardableStateChange) {

TabManager* tab_manager = g_browser_process->GetTabManager();

- ASSERT_TRUE(tab_manager);

auto tsm = browser()->tab_strip_model();

set_tab_strip_model(tsm);

« no previous file with comments | « chrome/browser/memory/tab_manager_browsertest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »