Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2244363003: Mojo C++ bindings: disallow copy and assign for generated classes when necessary. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: disallow copy and assign for generated classes when necessary. On windows, if a generated class contains non-copyable members and we export it without explicitly disallowing copy and assign, compilation will fail in some cases. (An example could be found in test_export.mojom.) BUG=None Committed: https://crrev.com/9e060aa1a208f152f7a022879c95d3810281a75a Cr-Commit-Position: refs/heads/master@{#412051}

Patch Set 1 : regression test case #

Patch Set 2 : the actual fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/cpp/bindings/tests/mojo_test_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 1 chunk +17 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/test_export.mojom View 1 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 2 chunks +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks!
4 years, 4 months ago (2016-08-15 20:00:45 UTC) #7
darin (slow to review)
LGTM
4 years, 4 months ago (2016-08-15 21:00:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244363003/20001
4 years, 4 months ago (2016-08-15 21:11:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 21:15:02 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 21:23:11 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e060aa1a208f152f7a022879c95d3810281a75a
Cr-Commit-Position: refs/heads/master@{#412051}

Powered by Google App Engine
This is Rietveld 408576698