Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2248743003: [not for commit] try out fix with darin's cl.

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, yhirano+watch_chromium.org, jam, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, loading-reviews_chromium.org, haraken, Nate Chapin, tyoshino+watch_chromium.org, Aaron Boodman, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@44_fix_copy_assign
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[not for commit] try out fix with darin's cl. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -1112 lines) Patch
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/websockets/websocket_impl.h View 5 chunks +12 lines, -12 lines 0 comments Download
M content/browser/websockets/websocket_impl.cc View 7 chunks +23 lines, -28 lines 0 comments Download
M content/browser/websockets/websocket_manager.h View 3 chunks +7 lines, -10 lines 0 comments Download
M content/browser/websockets/websocket_manager.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/websockets/websocket_manager_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/websocket.mojom View 1 chunk +0 lines, -138 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D content/renderer/websockethandle_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/renderer/websockethandle_impl.cc View 1 chunk +0 lines, -302 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 3 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 8 chunks +20 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 7 chunks +16 lines, -20 lines 0 comments Download
A + third_party/WebKit/Source/modules/websockets/WebSocketHandle.h View 3 chunks +38 lines, -11 lines 0 comments Download
A third_party/WebKit/Source/modules/websockets/WebSocketHandle.cpp View 1 chunk +242 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/websockets/WebSocketHandleClient.h View 2 chunks +9 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/exported/WebSocketHandshakeRequestInfo.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/platform/exported/WebSocketHandshakeResponseInfo.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/modules/websockets/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandshakeRequestInfo.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/public/platform/modules/websockets/WebSocketHandshakeResponseInfo.h View 1 chunk +0 lines, -63 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/websockets/websocket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 2244363003 Patch 20001

Messages

Total messages: 4 (4 generated)
yzshen1
The CQ bit was checked by yzshen@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-15 20:07:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248743003/1
4 years, 4 months ago (2016-08-15 20:07:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-15 20:42:29 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:42:30 UTC) #4 
Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

Powered by Google App Engine
This is Rietveld 408576698