mojo/public/interfaces/bindings/tests/test_export.mojom - Issue 2244363003: Mojo C++ bindings: disallow copy and assign for generated classes when necessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/test_export.mojom

Issue 2244363003: Mojo C++ bindings: disallow copy and assign for generated classes when necessary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: the actual fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/test_export.mojom

diff --git a/mojo/public/interfaces/bindings/tests/test_export.mojom b/mojo/public/interfaces/bindings/tests/test_export.mojom

new file mode 100644

index 0000000000000000000000000000000000000000..9a532dd94d42a0a712f50f68c1120735724a1750

--- /dev/null

+++ b/mojo/public/interfaces/bindings/tests/test_export.mojom

@@ -0,0 +1,18 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+module mojo.test.test_export;

+struct StringPair {

+ string s1;

+ string s2;

+};

+// This is a regression test. On Windows, if we export the generated class *and*

+// not explicitly disallow copy constructor and assign operator, compilation

+// will fail because it tries to use copy constructor of

+// InlinedStructPtr<StringPair>.

+struct StringPairContainer {

+ array<StringPair> pairs;

+};