[SVGDom] SVGPong sample app

[SVGDom] SVGPong sample app

Shows off SVG dom-based animations.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243853003

Committed: https://skia.googlesource.com/skia/+/ca39d716f10e75e3a2449262e67584f46d589c26

[f(malita), 2016-08-12 15:25:46]

Description was changed from

==========
[SVGDom] SVGPong sample app

Shows off SVG dom-based animations.

R=robertphillips@google.com,stephana@google.com
==========

to

==========
[SVGDom] SVGPong sample app

Shows off SVG dom-based animations.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243853003
==========

[f(malita), 2016-08-12 16:14:17]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:14:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-08-12 16:33:22]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:33:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 16:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 16:42:19]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[f(malita), 2016-08-12 16:44:32]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:44:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:05:52]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-12 18:15:19]

lgtm. I'm kind of bummed that the user can't control one of the paddles.

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
File samplecode/SampleSVGPong.cpp (right):

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
samplecode/SampleSVGPong.cpp:45: // map to [0, P)
one line ?

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
samplecode/SampleSVGPong.cpp:58: const SkScalar edge = spd.fX > 0 ? box.fRight :
box.fLeft;
put assert on its own line ?

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
samplecode/SampleSVGPong.cpp:61: 
one line ?

[f(malita), 2016-08-12 18:27:11]

On 2016/08/12 18:15:19, robertphillips wrote:
> I'm kind of bummed that the user can't control one of the paddles.

That was totally my plan, but couldn't figure how to receive mouse move events
in the view impl.  Maybe it's possible, or maybe we could use keys instead
(ugh).  Future feature :)

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
File samplecode/SampleSVGPong.cpp (right):

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
samplecode/SampleSVGPong.cpp:45: // map to [0, P)
On 2016/08/12 18:15:19, robertphillips wrote:
> one line ?

Done.

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
samplecode/SampleSVGPong.cpp:58: const SkScalar edge = spd.fX > 0 ? box.fRight :
box.fLeft;
On 2016/08/12 18:15:18, robertphillips wrote:
> put assert on its own line ?

Done.

https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
samplecode/SampleSVGPong.cpp:61: 
On 2016/08/12 18:15:19, robertphillips wrote:
> one line ?

Done.

[f(malita), 2016-08-12 19:21:38]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-12 19:21:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2243853003/#ps150001
(title: "review")

[stephana, 2016-08-12 19:21:45]

On 2016/08/12 18:27:11, f(malita) wrote:
> On 2016/08/12 18:15:19, robertphillips wrote:
> > I'm kind of bummed that the user can't control one of the paddles.
> 
> That was totally my plan, but couldn't figure how to receive mouse move events
> in the view impl.  Maybe it's possible, or maybe we could use keys instead
> (ugh).  Future feature :)
> 
>
https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
> File samplecode/SampleSVGPong.cpp (right):
> 
>
https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
> samplecode/SampleSVGPong.cpp:45: // map to [0, P)
> On 2016/08/12 18:15:19, robertphillips wrote:
> > one line ?
> 
> Done.
> 
>
https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
> samplecode/SampleSVGPong.cpp:58: const SkScalar edge = spd.fX > 0 ? box.fRight
:
> box.fLeft;
> On 2016/08/12 18:15:18, robertphillips wrote:
> > put assert on its own line ?
> 
> Done.
> 
>
https://codereview.chromium.org/2243853003/diff/130001/samplecode/SampleSVGPo...
> samplecode/SampleSVGPong.cpp:61: 
> On 2016/08/12 18:15:19, robertphillips wrote:
> > one line ?
> 
> Done.

LGTM

[commit-bot: I haz the power, 2016-08-12 19:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:17:13]

Description was changed from

==========
[SVGDom] SVGPong sample app

Shows off SVG dom-based animations.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243853003
==========

to

==========
[SVGDom] SVGPong sample app

Shows off SVG dom-based animations.

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243853003

Committed:
https://skia.googlesource.com/skia/+/ca39d716f10e75e3a2449262e67584f46d589c26
==========

[commit-bot: I haz the power, 2016-08-12 20:17:14]

Committed patchset #9 (id:150001) as
https://skia.googlesource.com/skia/+/ca39d716f10e75e3a2449262e67584f46d589c26