Add OnDurationChange() to RenderClient

Add OnDurationChange() to RenderClient

Currently, only the DemuxerHost interface allows the propragation of
duration changes; the demuxer is responsible for detecting duration
changes and notifying the Pipeline.

In the case of the MediaPlayerRenderer, we use a MediaUrlDemuxer, which
never receives duration updates. Instead, all metadata parsing happens
on the browser side, in the MediaPlayerRenderer. We therefore need a
way to propagate the duration changes from the MediaPlayerRenderer to
the pipeline.

This change adds an OnDurationChange method to both the
media::RendererClient and the mojom::RendererClient interfaces.

BUG=635991
Committed: https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc
Cr-Commit-Position: refs/heads/master@{#411893}

[tguilbert, 2016-08-11 23:07:29]

tguilbert@chromium.org changed reviewers:
+ dalecurtis@chromium.org, watk@chromium.org

[tguilbert, 2016-08-11 23:07:30]

PTAL. Will add security reviewer after getting LGTM from the media team.

FYI, I had discussed this change with xhwang@ offline and he was fine with the
idea behind it, as outlined in his comment here:
https://chromiumcodereview.appspot.com/2075303002/diff/40001/media/base/rende...

[tguilbert, 2016-08-11 23:09:46]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:10:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 00:31:16]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-08-12 00:36:48]

lgtm

[watk, 2016-08-12 00:49:06]

lgtm

https://codereview.chromium.org/2243683002/diff/1/media/mojo/clients/mojo_ren...
File media/mojo/clients/mojo_renderer.h (right):

https://codereview.chromium.org/2243683002/diff/1/media/mojo/clients/mojo_ren...
media/mojo/clients/mojo_renderer.h:70: void OnDurationChange(int64_t
duration_usec) override;
Not sure if there's a reason we don't use TimeDelta in mojo interfaces, but I
filed a bug to switch anyway
https://bugs.chromium.org/p/chromium/issues/detail?id=637151

https://codereview.chromium.org/2243683002/diff/1/media/renderers/renderer_im...
File media/renderers/renderer_impl.cc (right):

https://codereview.chromium.org/2243683002/diff/1/media/renderers/renderer_im...
media/renderers/renderer_impl.cc:63: // scenarios, none of which should arrise
for RendererClientInternal.
arise

[tguilbert, 2016-08-12 00:58:15]

tguilbert@chromium.org changed reviewers:
+ ochang@chromium.org

[tguilbert, 2016-08-12 00:58:16]

+ochang, can you take a look at the media/mojo/interfaces/renderer.mojom change
from a security POV?

Thank you so much!
Thomas

https://codereview.chromium.org/2243683002/diff/1/media/mojo/clients/mojo_ren...
File media/mojo/clients/mojo_renderer.h (right):

https://codereview.chromium.org/2243683002/diff/1/media/mojo/clients/mojo_ren...
media/mojo/clients/mojo_renderer.h:70: void OnDurationChange(int64_t
duration_usec) override;
On 2016/08/12 00:49:06, watk wrote:
> Not sure if there's a reason we don't use TimeDelta in mojo interfaces, but I
> filed a bug to switch anyway
> https://bugs.chromium.org/p/chromium/issues/detail?id=637151

Good point! Thanks for opening this.

https://codereview.chromium.org/2243683002/diff/1/media/renderers/renderer_im...
File media/renderers/renderer_impl.cc (right):

https://codereview.chromium.org/2243683002/diff/1/media/renderers/renderer_im...
media/renderers/renderer_impl.cc:63: // scenarios, none of which should arrise
for RendererClientInternal.
On 2016/08/12 00:49:06, watk wrote:
> arise

Done.

[Oliver Chang, 2016-08-12 03:20:59]

security lgtm

[tguilbert, 2016-08-12 19:30:00]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2016-08-12 19:30:01]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2243683002/#ps20001
(title: "Fixed typo")

[commit-bot: I haz the power, 2016-08-12 19:30:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 22:18:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:18:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tguilbert, 2016-08-12 23:10:20]

The CQ bit was checked by tguilbert@chromium.org

[commit-bot: I haz the power, 2016-08-12 23:10:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 03:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 03:51:17]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tguilbert, 2016-08-13 08:13:03]

The CQ bit was checked by tguilbert@chromium.org

[commit-bot: I haz the power, 2016-08-13 08:13:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 12:12:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-13 12:13:46]

Description was changed from

==========
Add OnDurationChange() to RenderClient

Currently, only the DemuxerHost interface allows the propragation of
duration changes; the demuxer is responsible for detecting duration
changes and notifying the Pipeline.

In the case of the MediaPlayerRenderer, we use a MediaUrlDemuxer, which
never receives duration updates. Instead, all metadata parsing happens
on the browser side, in the MediaPlayerRenderer. We therefore need a
way to propagate the duration changes from the MediaPlayerRenderer to
the pipeline.

This change adds an OnDurationChange method to both the
media::RendererClient and the mojom::RendererClient interfaces.

BUG=635991
==========

to

==========
Add OnDurationChange() to RenderClient

Currently, only the DemuxerHost interface allows the propragation of
duration changes; the demuxer is responsible for detecting duration
changes and notifying the Pipeline.

In the case of the MediaPlayerRenderer, we use a MediaUrlDemuxer, which
never receives duration updates. Instead, all metadata parsing happens
on the browser side, in the MediaPlayerRenderer. We therefore need a
way to propagate the duration changes from the MediaPlayerRenderer to
the pipeline.

This change adds an OnDurationChange method to both the
media::RendererClient and the mojom::RendererClient interfaces.

BUG=635991

Committed: https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc
Cr-Commit-Position: refs/heads/master@{#411893}
==========

[commit-bot: I haz the power, 2016-08-13 12:13:48]

Patchset 2 (id:??) landed as
https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc
Cr-Commit-Position: refs/heads/master@{#411893}