Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2240213003: Update media mojom files to use TimeDelta instead of int64 (Closed)

Created:
4 years, 4 months ago by tguilbert
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@OnDurationChanged_CL
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update media mojom files to use TimeDelta instead of int64 Native support for base::TimeDelta was added at the end of May (see 6ae5d56453c79e8377e255f153ce8fe8cafa4d2d) This change updates the //media/mojo/interfaces/*.mojom to use mojo.common.mojom.TimeDelta instead of int64, and updates the implementations of those interfaces. BUG=637151 Committed: https://crrev.com/e79bbf93e15d8fd6a16b19ea7e9a54994204f9cc Cr-Commit-Position: refs/heads/master@{#412050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -65 lines) Patch
M media/mojo/clients/mojo_renderer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 9 chunks +16 lines, -25 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 7 chunks +11 lines, -10 lines 0 comments Download
M media/mojo/interfaces/renderer.mojom View 4 chunks +10 lines, -8 lines 0 comments Download
M media/mojo/services/media_mojo_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 4 chunks +7 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
tguilbert
PTAL. This change is also still waiting on the CQ from https://codereview.chromium.org/2243683002/ to finish. Thanks! ...
4 years, 4 months ago (2016-08-13 01:01:45 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 4 months ago (2016-08-13 01:15:35 UTC) #3
tguilbert
dcheng, can you please review security changes in media/mojo/interfaces/*? The change is simply going from ...
4 years, 4 months ago (2016-08-13 01:24:53 UTC) #5
dcheng
LGTM Out of curiosity, does this have any affect on binary size?
4 years, 4 months ago (2016-08-13 02:20:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240213003/1
4 years, 4 months ago (2016-08-15 19:07:59 UTC) #8
tguilbert
On 2016/08/13 02:20:40, dcheng wrote: > LGTM > > Out of curiosity, does this have ...
4 years, 4 months ago (2016-08-15 19:35:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 21:12:58 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 21:16:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e79bbf93e15d8fd6a16b19ea7e9a54994204f9cc
Cr-Commit-Position: refs/heads/master@{#412050}

Powered by Google App Engine
This is Rietveld 408576698