content/browser/media/android/media_player_renderer.cc - Issue 2243683002: Add OnDurationChange() to RenderClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/android/media_player_renderer.cc

Issue 2243683002: Add OnDurationChange() to RenderClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_player_simplified

Patch Set: Fixed typo Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/media/android/media_player_renderer.cc

diff --git a/content/browser/media/android/media_player_renderer.cc b/content/browser/media/android/media_player_renderer.cc

index dc7b790fa69dd6bfb24922238aa79d4bd15136ff..3b7708bbce62af48e2a30ff7c2c19da426833f08 100644

--- a/content/browser/media/android/media_player_renderer.cc

+++ b/content/browser/media/android/media_player_renderer.cc

@@ -153,8 +153,7 @@ void MediaPlayerRenderer::OnMediaMetadataChanged(int player_id,

if (duration_ != duration) {

duration_ = duration;

- // TODO(tguilbert): Add OnDurationChange to the RendererClient interface.

- // See crbug.com/635991.

+ renderer_client_->OnDurationChange(duration);

}

« no previous file with comments | « no previous file | content/renderer/media/android/media_player_renderer_client.h » ('j') | no next file with comments »