Adding overflow menu to media player

third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
index c9aa995280ae8e19d2a823355e5b4e0ec8ad926f..1aabf2f8c4df4ef63c5cc25c5b0389a2861d999b 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
@@ -31,6 +31,7 @@
 #define MediaControlElements_h
 
 #include "core/html/shadow/MediaControlElementTypes.h"
+#include <set>
 
 namespace blink {
 
@@ -94,6 +95,8 @@ public:
     bool willRespondToMouseClickEvents() override { return true; }
     void updateDisplayType() override;
 
+    String getText() override;
+
 private:
     explicit MediaControlMuteButtonElement(MediaControls&);
 
@@ -140,6 +143,8 @@ public:
 
     void updateDisplayType() override;
 
+    String getText() override;
+
 private:
     explicit MediaControlToggleClosedCaptionsButtonElement(MediaControls&);
 
@@ -173,6 +178,42 @@ private:
 };
 
 // ----------------------------
+// Represents the overflow menu which is displayed when the width of the media
+// player is small enough that at least two buttons are no longer visible.
+class MediaControlOverflowMenu final : public MediaControlInputElement {

[liberato (no reviews please), 2016/08/24 16:44:22]

might want to include "Button" in the class name.  that's consistent with the
other button classes.  plus, in this case, it avoids confusion with the
MediaControlOverflowMenuListElement.  "OverflowMenu" sounds like it could be the
latter.

[kdsilva, 2016/08/26 18:11:03]

Done.

+public:
+    static MediaControlOverflowMenu* create(MediaControls&);
+
+    // The overflow button should respond to mouse clicks since we want a click
+    // to open up the menu.
+    bool willRespondToMouseClickEvents() override { return true; }
+
+private:
+    explicit MediaControlOverflowMenu(MediaControls&);
+
+    void defaultEventHandler(Event*) override;
+};
+
+// ----------------------------
+// Holds a list of elements within the overflow menu.
+class MediaControlOverflowMenuListElement final : public MediaControlDivElement {
+public:
+    static MediaControlOverflowMenuListElement* create(MediaControls&);
+
+    // A set of the MediaControlElementTypes that should appear in the
+    // overflow menu.
+    void setOverflowMenuControls(const std::set<MediaControlElementType>*);
+
+    // True to display overflow menu, false to hide.
+    void showOverflowMenu(bool);
+
+private:
+    explicit MediaControlOverflowMenuListElement(MediaControls&);
+
+    void defaultEventHandler(Event*) override;
+};
+
+// ----------------------------
 
 class MediaControlTimelineElement final : public MediaControlInputElement {
 public:
@@ -184,7 +225,6 @@ public:
     // is supported by HTMLMediaElement, see https://crbug.com/137275
     void setPosition(double);
     void setDuration(double);
-
 private:
     explicit MediaControlTimelineElement(MediaControls&);
 
@@ -202,6 +242,8 @@ public:
 
     void setIsFullscreen(bool);
 
+    String getText() override;
+
 private:
     explicit MediaControlFullscreenButtonElement(MediaControls&);
 
@@ -218,6 +260,8 @@ public:
 
     void setIsPlayingRemotely(bool);
 
+    String getText() override;
+
     // This will show a cast button if it is not covered by another element.
     // This MUST be called for cast button elements that are overlay elements.
     void tryShowOverlay();