third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h - Issue 2243473002: Adding overflow menu to media player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/mediaControlsNew.css ('K') | « third_party/WebKit/Source/core/css/mediaControlsNew.css ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.h » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

index cabfb86e924f2d3dcca320a6ce64e7e978cad6fb..ff89c4ef877bde7eca19ab86cbeb57da9563d083 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

@@ -87,6 +87,10 @@ public:

// needed, also.

void setDoesFit(bool);

+ // Returns a string representation of the media control element. Used for

+ // the overflow menu.

+ virtual String getText() { return String(); }

MediaControlElementType displayType() const { return m_displayType; }

DECLARE_VIRTUAL_TRACE();